httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Donovan <donov...@bellatlantic.net>
Subject Re: svn commit: r683465 - /httpd/httpd/branches/2.2.x/STATUS
Date Thu, 07 Aug 2008 12:09:56 GMT
Nick Kew wrote:
> On Thu, 07 Aug 2008 01:30:49 -0000
> tdonovan@apache.org wrote:
> 
>> remove proposal accidentally added twice
> 
> I was about to ask whether you planned to vote on the other
> instance of it, when I saw:

Looking at the "backport to 2.2" votes in STATUS, they all seem to be from experienced httpd

maintainers; so I was unsure if I should vote myself or wait for three +1's from others before

proceeding.

>> -      Trunk version of patch:
>> -         http://svn.apache.org/viewvc?rev=670061&view=rev
>> -         http://svn.apache.org/viewvc?rev=670198&view=rev

> 
> That's actually different: only the first patch was already proposed.
> Maybe you'd like to clarify?

r670061 was my first attempt to fix it.

Ruediger pointed out that this change could break forward proxies in
   http://article.gmane.org/gmane.comp.apache.devel/34670
so I corrected the fix in r670198.

The (original) proposed patch
   http://people.apache.org/~tdonovan/diffs/mod_rewrite_proxy_esc_2.2.x.diff
combines both the r670061 and r670198 changes
   http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mappers/mod_rewrite.c?r1=664333&r2=670198

-tom-


Mime
View raw message