httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r682369 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Date Mon, 04 Aug 2008 13:54:29 GMT


On 08/04/2008 03:50 PM, Mladen Turk wrote:
> rpluem@apache.org wrote:
>> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
>> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Mon Aug  4 05:53:50 2008
>> @@ -1380,7 +1380,6 @@
>>      proxy_worker *worker = (proxy_worker *)theworker;
>>      if (worker->cp->res) {
>>          worker->cp->pool = NULL;
>> -        apr_reslist_destroy(worker->cp->res);
>>      }
>>      return APR_SUCCESS;
>>  }
>>
> 
> Well, you've beat me :)
> The complete conn_pool_cleanup function can be omitted, and
> there is no need for checking  if (conn->worker->cp->pool)
> in the connection_destructor.

Might be. At the current state it makes it possible to keep
trunk and 2.2.x very similar until all in apr land is sorted
out. We can cleanup the remaining parts then.

Regards

RĂ¼diger


Mime
View raw message