httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: worker MPM on trunk does not shut down cleanly
Date Fri, 01 Aug 2008 08:44:18 GMT
Ruediger Pluem wrote:
> Ok, this is caused by http://svn.apache.org/viewvc?rev=677505&view=rev
> This is the reslist pre_cleanup patch. I don't know why so far, but as
> I have a proxy configuration I suspect that it blocks on tearing down
> the proxy connection pools.
> 

Here is the fix for trunk.

Index: proxy_util.c
===================================================================
--- proxy_util.c        (revision 681621)
+++ proxy_util.c        (working copy)
@@ -1939,10 +1939,11 @@
                                  worker->hmax, worker->ttl,
                                  connection_constructor, 
connection_destructor,
                                  worker, worker->cp->pool);
-
+#if 0
          apr_pool_cleanup_register(worker->cp->pool, (void *)worker,
                                    conn_pool_cleanup,
                                    apr_pool_cleanup_null);
+#endif



Note that because of using pre_cleanup in reslist we don't need
the extra registered cleanup (conn_pool_cleanup),
just to make sure the ordering is correct.
This was bogus anyhow, because we were destroying the reslist in
cleanup (that already has it's own cleanup), so the ordering of
cleanup callbacks was essential.


Regards
-- 
^(TM)

Mime
View raw message