httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sander Temme <scte...@apache.org>
Subject Re: [PATCH] Dynamic locking upcalls in mod_ssl
Date Thu, 21 Aug 2008 03:52:49 GMT

On Aug 20, 2008, at 11:56 AM, Plüm, Rüdiger, VF-Group wrote:

> You should set dynlockpool to NULL here as well. In case it is used  
> afterwards
> things segfault and are easier to detected than when an invalid  
> pointer is used.
> This should basicly address your question regarding the reference on  
> a pool
> in global variable as well.


Thanks Rüdiger, that's great feedback.  With that, and a test run on  
my Linux box where it responded successfully to a restart, a graceful  
and a stop interspersed with ab runs that raised the number of worker  
children, I'll commit.  Where the whole thing will of course be up for  
further review and consideration.

S.

-- 
Sander Temme
sctemme@apache.org
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF




Mime
View raw message