httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jordi Prats" <jordi.pr...@gmail.com>
Subject mod_status slots
Date Fri, 08 Aug 2008 08:12:11 GMT
Hi all,
I've seen that mod_status shows the number of slots available as the
ServerLimit directive. In my opinion this is not meaningful because if
you set the MaxClient directive to a lower value it does not reflect
on the available slots on mod_status.

I would like to suggest to change this behaviour by just changing a line:

diff -Naur httpd-orig/modules/generators/mod_status.c
httpd-mod/modules/generators/mod_status.c
--- httpd-orig/modules/generators/mod_status.c  2008-01-02
10:43:52.000000000 +0100
+++ httpd-mod/modules/generators/mod_status.c   2008-08-08
10:04:26.000000000 +0200
@@ -848,7 +848,7 @@
     status_flags[SERVER_GRACEFUL] = 'G';
     status_flags[SERVER_IDLE_KILL] = 'I';
     ap_mpm_query(AP_MPMQ_HARD_LIMIT_THREADS, &thread_limit);
-    ap_mpm_query(AP_MPMQ_HARD_LIMIT_DAEMONS, &server_limit);
+    ap_mpm_query(AP_MPMQ_MAX_DAEMON_USED, &server_limit);
     return OK;
 }


I don't know about other implications of changing this line. I've just
tested it using prefork both restarting and reloading apache. What do
you think about this little change?


regards,
-- 
Jordi

Mime
View raw message