httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jorge Schrauwen" <jorge.schrau...@gmail.com>
Subject Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Date Tue, 24 Jun 2008 15:42:02 GMT
Compiles fine and is working as before on gentoo...
named vhosting still broken though

[ X ] +1 to release as 0.9.2-beta

~Jorge

On Sat, Jun 21, 2008 at 9:17 AM, Takashi Sato <takashi@lans-tv.com> wrote:

> On Tue, 17 Jun 2008 16:43:14 -0500
> "William A. Rowe, Jr." <wrowe@rowe-clan.net> wrote:
>
> >    [ ] -1 for any release of 0.9.2
> >    [ ] +1 to release as 0.9.2-alpha
> >    [ ] +1 to release as 0.9.2-beta
> >    [ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0)
>
> -0
>
> ftp_commands.c: In function 'ftp_cmd_pbsz':
> ftp_commands.c:1706: warning: comparison is always false due to limited
> range of data type
>
> If 'arg' is "2147483647"
> on the sizeof(int) == 4 == sizeof(long)  system,
> fc->pbsz == LONG_MAX.
> But on the sizeof(int) == 4 < sizeof(long) system,
> fc->pbsz != LONG_MAX.
>
> I have not read the code deeply, but I think this is not quite dangerous.
> There is no code using pbsz.
> I have found other assignments of resutl of strtol to int.
>
> mod_ftp.c line 406
> *(int *) ((char *) fsc + offset) = strtol(arg, &endptr, 10);
> line 436
> umask = strtol(arg, &endp, 8);
> line 459
> umask = strtol(arg, &endp, 8);
>
> My environment:
> FreeBSD 7-STABLE AMD64
> gcc version 4.2.1 20070719  [FreeBSD]
>

Mime
View raw message