Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of mirkperl@gmail.com designates
 66.249.92.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=G/Y2+p+5nN7eYdP2krnI7p0+KFw1NKD7YRBnoeeNn3srmtRKD+S8RLJay8cPsHYwAC4VxxkX+1HTpIYMIseFtxkS3mak5Q4R8iQiuklbf5Fr7BLmnW6zOUDvOS5v+t8olj25VUvavp7KY1MtUrh3aX0E1MDrLNQKJ3qIJ+lESEA=
Message-ID: <aafb0e350805211334o41420d01tc079a060fe67151b@mail.gmail.com>
Date: Wed, 21 May 2008 16:34:07 -0400
From: "Adam Woodworth" <mirkperl@gmail.com>
To: dev@httpd.apache.org
Subject: Re: mod_proxy race condition bug #37770
In-Reply-To: <aafb0e350805191401w2da1f21esb039edf5bf6afecf@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <aafb0e350805121052g74102f86v18e527c1a50b35a2@mail.gmail.com>
	 <aafb0e350805161421v10417b9dl573fdcf12fd6c8c5@mail.gmail.com>
	 <482F30D2.90507@apache.org>
	 <aafb0e350805190909w8a33b43nc627e0289612732e@mail.gmail.com>
	 <4831D273.2050502@apache.org>
	 <aafb0e350805191236x5940070bm824490d17ea6d475@mail.gmail.com>
	 <4831DE7E.8020106@apache.org>
	 <aafb0e350805191328p7da0a55bk56ae9457902bae28@mail.gmail.com>
	 <aafb0e350805191351k1ddc4d14l402d59b825a109fd@mail.gmail.com>
	 <aafb0e350805191401w2da1f21esb039edf5bf6afecf@mail.gmail.com>

I think there is a problem with r657443 (and thus I assume r645813):

I applied the r657443 patch to my copy of the 2.2.8 official release
source and it doesn't work right.  The problem is that the change to
mod_proxy_http.c checks c->keepalives for a value, but c->keepalives
is filled out by ap_http_header_filter(), which isn't called until
later.  So, c->keepalives is always 0 at this point.  Which also means
that the "number of keepalives" message in the ap_log_rerror() msg
isn't going to mean anything, but at this point it never reaches it.

Also, I "patched the patch" to manually set c->keepalives to 1 for
testing so that I could test out this r657443 patch.  However, what
happened was that Apache would kick back an error page to the client,
instead of just closing the connection.  So, no improvement.

Has this patch been tested and verified anywhere?