httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, VF-Group <ruediger.pl...@vodafone.com>
Subject Re: svn commit: r646285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_auth_form.xml modules/aaa/config.m4 modules/aaa/mod_auth_form.c
Date Fri, 02 May 2008 07:18:08 GMT
 

> -----Ursprüngliche Nachricht-----
> Von: Graham Leggett 
> Gesendet: Freitag, 2. Mai 2008 00:01
> An: dev@httpd.apache.org
> Betreff: Re: svn commit: r646285 - in /httpd/httpd/trunk: 
> CHANGES docs/manual/mod/mod_auth_form.xml 
> modules/aaa/config.m4 modules/aaa/mod_auth_form.c
> 
> Ruediger Pluem wrote:
> 

> >> +                apr_table_set(r->headers_out, "Location", 
> sent_loc);
> >> +                return HTTP_MOVED_PERMANENTLY;
> > 
> > Shouldn't this be HTTP_TEMPORARY_REDIRECT?
> 
> Not sure, can you explain why it would be temporary?

Because the login page is not what should be displayed normally. It should
only get displayed if the user is not logged in. IMHO HTTP_MOVED_PERMANENTLY
is cachable whereas HTTP_TEMPORARY_REDIRECT is not.

> 
> >> +    /* return the underlying error, or OK on success */
> >> +    return r->status == HTTP_OK || r->status == OK ? OK : 
> r->status;
> > 
> > Why not returning r->status here directly?
> 
> Because when it did as I recall, the HTTP_OK value triggered 
> the error 
> document handler, which broke the request.

Ah, ok. Looking at the code this makes sense.

Regards

Rüdiger

Mime
View raw message