httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: [BUG] : pre_config_hook issues
Date Mon, 26 May 2008 07:59:05 GMT


On 05/26/2008 09:21 AM, MENEAULT Maxime wrote:
> Hi all!
> 
> I am posting to the list to confirm a bug I just noticed while 
> developing modules for Apache.
> 
> Apparently pre_config hooks are not ordered when ap_run_pre_config is 
> called.
> I noticed and verified one issue and I noticed another one 
> (syntactically only) while reading through the code.
> 
> First issue (verified):
> While during the first configuration pass pre_config hooks seem to be 
> ordered for prelinked modules during the second one hooks are not 
> ordered (i.e. not in the order specified by APR_HOOK_FIRST...defines).
> Fix:
> apr_hook_sort_all is called too late during second and further 
> configuration passes.
> It needs to be called before ap_run_pre_config (l.699 of server/main.c).
> 
> Second issue (only noticed while reading the code):
> pre_config hooks might not be ordered for dynamically loaded modules 
> even during first configuration pass.
> Fix:
> apr_hook_sort_all needs to be called before ap_run_pre_config (l.627 of 
> server/main.c)
> 
> I pasted a patch below to fix both issues.
> 
> Any comments are welcome.
> Should I fill-in a bug report?

Yes, please and attach your patch as an attachment. This should avoid that this
falls of the plate. BTW: We prefer patches against trunk, but I guess in your case
this make no difference.

Regards

RĂ¼diger


Mime
View raw message