httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: svn commit: r660461 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c
Date Tue, 27 May 2008 13:53:56 GMT
On Tue, 27 May 2008 10:50:24 -0000
rpluem@apache.org wrote:

> Author: rpluem
> Date: Tue May 27 03:50:23 2008
> New Revision: 660461
> 
> URL: http://svn.apache.org/viewvc?rev=660461&view=rev
> Log:
> * Handle the case that secure is NULL
> 
> Modified:
>     httpd/httpd/trunk/modules/mappers/mod_rewrite.c
> 
> Modified: httpd/httpd/trunk/modules/mappers/mod_rewrite.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mappers/mod_rewrite.c?rev=660461&r1=660460&r2=660461&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/mappers/mod_rewrite.c (original) +++
> httpd/httpd/trunk/modules/mappers/mod_rewrite.c Tue May 27 03:50:23
> 2008 @@ -2492,7 +2492,9 @@ "; domain=", domain,
>                                   expires ? "; expires=" : NULL,
>                                   expires ? exp_time : NULL,
> -                                 (strcasecmp(secure, "true") == 0 ||
> strcasecmp(secure, "1") == 0) ? "; secure" : NULL,
> +                                 secure ? ((strcasecmp(secure,
> "true") == 0
> +                                           || strcasecmp(secure,
> "1") == 0) ?
> +                                           "; secure" : NULL) : NULL,
>                                   httponly ? "; HttpOnly" : NULL, 
>                                   NULL);

Fixes the expected segfault, but should it be more robust?
As in, check the value of httponly rather than rely on it
only having one non-NULL value in the spec?

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Mime
View raw message