Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 41395 invoked from network); 19 Apr 2008 18:49:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Apr 2008 18:49:56 -0000 Received: (qmail 98426 invoked by uid 500); 19 Apr 2008 18:49:54 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 98354 invoked by uid 500); 19 Apr 2008 18:49:54 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 98343 invoked by uid 99); 19 Apr 2008 18:49:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Apr 2008 11:49:54 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 19 Apr 2008 18:49:10 +0000 Received: (qmail 41327 invoked by uid 2161); 19 Apr 2008 18:49:29 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 4610F1721C for ; Sat, 19 Apr 2008 20:49:19 +0200 (CEST) Message-ID: <480A3EB1.3010301@apache.org> Date: Sat, 19 Apr 2008 20:49:21 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r649239 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_ajp.c mod_proxy_http.c References: <20080417192018.DD7D31A983A@eris.apache.org> <4807AEA7.3000209@apache.org> <99EA83DCDE961346AFA9B5EC33FEC08B8584C9@VF-MBX11.internal.vodafone.com> <3773AF2E-B52E-4F77-9D76-638E0D72B869@jaguNET.com> <4809C566.7090600@apache.org> <2132DB27-257D-4B76-AE00-2EE85D09AB49@jaguNET.com> In-Reply-To: <2132DB27-257D-4B76-AE00-2EE85D09AB49@jaguNET.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 04/19/2008 06:22 PM, Jim Jagielski wrote: > > On Apr 19, 2008, at 6:11 AM, Ruediger Pluem wrote: >> >> If you have no further objections I would commit it. >> > > Hmmmm.... from what I can see, the conditional for '(r->uri == > r->unparsed_uri)' > doesn't seem to be required anymore in our local code, so it > seems safe enough to remove. When that's done, the code reduces > to your patch... > > I am somewhat concerned about possible regressions with that > reduction however (hence my version which retained it - unless I > am confident that regression won't occur, I tend not to remove > legacy codepaths :) )... But I see no real reason not to commit So do I. But I am confident that there is no regression :-). I just committed (r649840). Lets see if I was wrong. Regards Rüdiger