Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 97850 invoked from network); 17 Apr 2008 19:05:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Apr 2008 19:05:02 -0000 Received: (qmail 26246 invoked by uid 500); 17 Apr 2008 19:04:58 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 26187 invoked by uid 500); 17 Apr 2008 19:04:58 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 26176 invoked by uid 99); 17 Apr 2008 19:04:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 12:04:58 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 17 Apr 2008 19:04:23 +0000 Received: (qmail 97585 invoked by uid 2161); 17 Apr 2008 19:04:36 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 6F7D51721C for ; Thu, 17 Apr 2008 21:04:23 +0200 (CEST) Message-ID: <48079F4A.8080903@apache.org> Date: Thu, 17 Apr 2008 21:04:42 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r649170 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c References: <20080417162421.D75AB1A9832@eris.apache.org> In-Reply-To: <20080417162421.D75AB1A9832@eris.apache.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 04/17/2008 06:24 PM, jim@apache.org wrote: > Author: jim > Date: Thu Apr 17 09:24:16 2008 > New Revision: 649170 > > URL: http://svn.apache.org/viewvc?rev=649170&view=rev > Log: > and make mod_proxy_fcgi also nocanon aware > > Modified: > httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c > > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c?rev=649170&r1=649169&r2=649170&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original) > +++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Thu Apr 17 09:24:16 2008 > @@ -103,8 +103,13 @@ > host = apr_pstrcat(r->pool, "[", host, "]", NULL); > } > > - path = ap_proxy_canonenc(r->pool, url, strlen(url), enc_path, 0, > + if (apr_table_get(r->notes, "proxy-nocanon")) { > + path = url; /* this is the raw path */ Is this correct? If it is the raw URL, url still contains the query args. This is not the case in the else branch. So we end up with different things regarding the query args. I am not sure how fcgi transfers the query args to the CGI. So I do not know what is the correct thing in this case. > + } > + else { > + path = ap_proxy_canonenc(r->pool, url, strlen(url), enc_path, 0, > r->proxyreq); > + } > if (path == NULL) > return HTTP_BAD_REQUEST; > Regards Rüdiger