Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 57170 invoked from network); 17 Apr 2008 15:39:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Apr 2008 15:39:22 -0000 Received: (qmail 68407 invoked by uid 500); 17 Apr 2008 15:39:14 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 68349 invoked by uid 500); 17 Apr 2008 15:39:14 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 68336 invoked by uid 99); 17 Apr 2008 15:39:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 08:39:14 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [209.133.199.10] (HELO jimsys.jaguNET.com) (209.133.199.10) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 15:38:31 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by jimsys.jaguNET.com (Postfix) with ESMTP id 5E6171157241 for ; Thu, 17 Apr 2008 11:38:27 -0400 (EDT) Message-Id: <3924DABD-2A43-4A89-AFAE-9B662973BA43@jaguNET.com> From: Jim Jagielski To: dev@httpd.apache.org In-Reply-To: <48076348.4080902@ptc.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Subject: Re: 2.2.9 (Was: Re: [PROPOSAL] Time Based Releases) Date: Thu, 17 Apr 2008 11:38:26 -0400 References: <4800EF78.6000100@force-elite.com> <48011314.3020405@apache.org> <5c902b9e0804130032l1e047b2cs3d46eb6c5c96d6b1@mail.gmail.com> <4803637B.9040700@ptc.com> <45AB0FB6-C4DE-4AB3-9CEB-52B5FE476E29@jaguNET.com> <4807121D.90000@gmail.com> <99EA83DCDE961346AFA9B5EC33FEC08B85834E@VF-MBX11.internal.vodafone.com> <480736D6.8030903@gmail.com> <48073B92.9070604@ptc.com> <48076348.4080902@ptc.com> X-Mailer: Apple Mail (2.919.2) X-Virus-Checked: Checked by ClamAV on apache.org On Apr 17, 2008, at 10:48 AM, Jess Holle wrote: > Jim Jagielski wrote: >> Can you try: >> >> Index: modules/proxy/mod_proxy_ajp.c >> =================================================================== >> --- modules/proxy/mod_proxy_ajp.c (revision 648735) >> +++ modules/proxy/mod_proxy_ajp.c (working copy) >> @@ -72,8 +72,13 @@ >> search = r->args; >> >> /* process path */ >> - path = ap_proxy_canonenc(r->pool, url, strlen(url), enc_path, 0, >> - r->proxyreq); >> + if (apr_table_get(r->notes, "proxy-nocanon")) { >> + path = url; /* this is the raw path */ >> + } >> + else { >> + path = ap_proxy_canonenc(r->pool, url, strlen(url), >> + enc_path, 0, r->proxyreq); >> + } >> if (path == NULL) >> return HTTP_BAD_REQUEST; > I don't do our Apache builds any more (and don't have things set up > to do so), but our engineer who does is slated to test the patch > attached to the bug soon. > > Is this the same as the patch attached to the bug report -- or a > different one? > This section is the same as that in the bug report (make mod_proxy_ajp aware of the nocanon EnvVar), but the attached patch also includes a workaround for the doubling of any query strings. This 2nd part needs to be addressed but the real fix may not be done by this patch. If you have no query args, then either is fine.