httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r649239 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_ajp.c mod_proxy_http.c
Date Fri, 18 Apr 2008 12:50:48 GMT

On Apr 17, 2008, at 4:10 PM, Ruediger Pluem wrote:
> Index: modules/proxy/mod_proxy_ajp.c
> ===================================================================
> --- modules/proxy/mod_proxy_ajp.c       (Revision 649232)
> +++ modules/proxy/mod_proxy_ajp.c       (Arbeitskopie)
> @@ -58,18 +58,8 @@
>
>     /*
>      * now parse path/search args, according to rfc1738
> -     *
> -     * N.B. if this isn't a true proxy request, then the URL _path_
> -     * has already been decoded.  True proxy requests have
> -     * r->uri == r->unparsed_uri, and no others have that property.
>      */
> -    if (r->uri == r->unparsed_uri) {
> -        search = strchr(url, '?');
> -        if (search != NULL)
> -            *(search++) = '\0';
> -    }
> -    else
> -        search = r->args;
> +    search = NULL;
>
>     /* process path */
>     if (apr_table_get(r->notes, "proxy-nocanon")) {
> @@ -78,6 +68,7 @@
>     else {
>         path = ap_proxy_canonenc(r->pool, url, strlen(url),  
> enc_path, 0,
>                                  r->proxyreq);
> +        search = r->args;
>     }
>     if (path == NULL)
>         return HTTP_BAD_REQUEST;

Ummm.... don't we still need to address the case where url
might include the query args?

Mime
View raw message