httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r649170 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
Date Thu, 17 Apr 2008 19:04:42 GMT


On 04/17/2008 06:24 PM, jim@apache.org wrote:
> Author: jim
> Date: Thu Apr 17 09:24:16 2008
> New Revision: 649170
> 
> URL: http://svn.apache.org/viewvc?rev=649170&view=rev
> Log:
> and make mod_proxy_fcgi also nocanon aware
> 
> Modified:
>     httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
> 
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c?rev=649170&r1=649169&r2=649170&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Thu Apr 17 09:24:16 2008
> @@ -103,8 +103,13 @@
>          host = apr_pstrcat(r->pool, "[", host, "]", NULL);
>      }
>  
> -    path = ap_proxy_canonenc(r->pool, url, strlen(url), enc_path, 0,
> +    if (apr_table_get(r->notes, "proxy-nocanon")) {
> +        path = url;   /* this is the raw path */

Is this correct? If it is the raw URL, url still contains the query args. This
is not the case in the else branch. So we end up with different things regarding the query
args. I am not sure how fcgi transfers the query args to the CGI. So I do not know what
is the correct thing in this case.

> +    }
> +    else {
> +        path = ap_proxy_canonenc(r->pool, url, strlen(url), enc_path, 0,
>                               r->proxyreq);
> +    }
>      if (path == NULL)
>          return HTTP_BAD_REQUEST;
>  

Regards

RĂ¼diger


Mime
View raw message