httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r646445 - in /httpd/httpd/trunk/modules/aaa: mod_auth_basic.c mod_auth_digest.c
Date Fri, 11 Apr 2008 10:24:20 GMT
On 11.04.2008 04:00, Chris Darroch wrote:
> Ruediger Pluem wrote:
> 
>> The implementation of the function. IMHO it must be the same in all
>> modules. Otherwise it depends on the module load order what gets
>> called and done.
> 
>   True -- an alternative might be to do the following:
> 
> - #define AUTHN/Z_PROVIDER_VERSION "0" in mod_auth.h
> - change all the authn/z modules to use #defines in place of hard-coded
>  "0" provider versions (maybe not a bad thing to do anyway)
> - #include mod_auth.h in request.c (mostly involves lots of fiddling
>  with config.m4 files and the like, for each platform)
> - eliminate the optional function call entirely
> 
>   I worked on this approach but concluded people might not appreciate
> all the changes to the config files and so forth, although the actual
> code per se is a little simpler and cleaner.  If this is preferred by
> a majority, though, I'm happy to implement it this way instead.  Thoughts?

So we are using the optional function only because we do not have the defines
for AUTHN_PROVIDER_GROUP and the version number around in request.c. If they
would be around it would be quite fine to call ap_list_provider_names directly
from there, correct?

Regards

R├╝diger



Mime
View raw message