httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c
Date Wed, 09 Apr 2008 16:33:37 GMT
On Wed, Apr 09, 2008 at 05:07:33PM +0200, Graham Leggett wrote:
> Joe Orton wrote:
>
>> I don't understand why *that* stuff needed to be in the core.  It is 
>> certainly possible to consume then reinject the request body, without 
>> changing one line of core filters; it's done in mod_ssl, see 
>> ssl_io_filter_buffer/ssl_io_buffer_fill.
>
> What about modules that call ap_discard_request_body? Once the body has 
> been discarded, the body is discarded, there is no way to get it back.

The entire request body passes through the input filter stack when it is 
being discarded.  So an input filter inserted by a module can capture 
and buffer it somewhere very easily; and can provide access to that 
buffered copy however it likes, without needing to modify request_rec.

joe

Mime
View raw message