httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c
Date Wed, 09 Apr 2008 14:18:31 GMT
On Wed, Apr 09, 2008 at 03:10:25PM +0200, Graham Leggett wrote:
> Roy T. Fielding wrote:
>
>> -1.  Bloat like this belongs in a module.
>
> This piece of code depends on the KeptBodySize directive, which is part of 
> the http_filter, and sits alongside ap_discard_request_body().

I don't understand why *that* stuff needed to be in the core.  It is 
certainly possible to consume then reinject the request body, without 
changing one line of core filters; it's done in mod_ssl, see 
ssl_io_filter_buffer/ssl_io_buffer_fill.

joe

Mime
View raw message