httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guy Ferraiolo <g...@cnet.com>
Subject Re: [Fwd: Re: more importuning about the flood patch]
Date Tue, 15 Apr 2008 23:42:11 GMT
Folks

I have the fixes for this and one other problem not mentioned that shows
up under gcc 4.  They amount to 3 lines.  There are other warnings from
parts of flood that I haven't touched so I'm going to keep my feet out
of those for now.  I'll submit my three line patch tomorrow.

The version of gcc I'm using is:
gcc version 4.1.1 20070105 (Red Hat 4.1.1-52)

Guy


On Mon, 2008-04-14 at 15:07 +0200, Oden Eriksson wrote:
> Den Monday 14 April 2008 12.32.25 skrev William A. Rowe, Jr.:
> > Confirming; this is the patch?
> >
> > Bill
> 
> Does not build for me (r647777) on Mandriva Linux 2008.1 (x86_64):
> 
> /bin/sh /usr/lib64/apr-1/build/libtool --silent --mode=compile 
> gcc    -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
  -pthread    -I/usr/include/include   -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE
-I/usr/include/apr-1   -I/usr/include/apr-1 -I/usr/include  -I. -I/home/oden/RPM/BUILD/flood
  -c 
> flood.c && touch flood.lo
> /bin/sh /usr/lib64/apr-1/build/libtool --silent --mode=compile 
> gcc    -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
  -pthread    -I/usr/include/include   -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE
-I/usr/include/apr-1   -I/usr/include/apr-1 -I/usr/include  -I. -I/home/oden/RPM/BUILD/flood
  -c 
> flood_round_robin.c && touch flood_round_robin.lo
> flood_round_robin.c: In function 'round_robin_profile_init':
> flood_round_robin.c:793: warning: comparison is always false due to limited 
> range of data type
> flood_round_robin.c:793: warning: comparison is always false due to limited 
> range of data type
> flood_round_robin.c:910: error: lvalue required as left operand of assignment
> flood_round_robin.c:920: error: lvalue required as left operand of assignment
> flood_round_robin.c: In function 'round_robin_postprocess':
> flood_round_robin.c:1086: warning: cast from pointer to integer of different 
> size
> flood_round_robin.c:1086: warning: cast from pointer to integer of different 
> size
> flood_round_robin.c:1097: warning: cast from pointer to integer of different 
> size
> flood_round_robin.c:1097: warning: cast from pointer to integer of different 
> size
> flood_round_robin.c:1236: warning: passing argument 3 of 'apr_file_write' from 
> incompatible pointer type
> 
> 
> 
> 
> 
-- 
Guy Ferraiolo                                   mailto:guyf@CNET.com
Performance Measurement & Analysis              http://CNET.com
CNET                                            tel: 1.908.541.3739
1200 Route 22 East                              fax: 1.908.575.7474
Bridgewater, NJ 08807                           cel: 1.732.618.0250

Mime
View raw message