Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 60377 invoked from network); 14 Feb 2008 20:38:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Feb 2008 20:38:36 -0000 Received: (qmail 73645 invoked by uid 500); 14 Feb 2008 20:38:28 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 73412 invoked by uid 500); 14 Feb 2008 20:38:27 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 73401 invoked by uid 99); 14 Feb 2008 20:38:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2008 12:38:27 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 14 Feb 2008 20:37:50 +0000 Received: (qmail 60259 invoked by uid 2161); 14 Feb 2008 20:38:09 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id AA9B21721C for ; Thu, 14 Feb 2008 21:37:58 +0100 (CET) Message-ID: <47B4A6BB.4000501@apache.org> Date: Thu, 14 Feb 2008 21:38:19 +0100 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080201 SeaMonkey/1.1.8 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r627728 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_proxy.xml modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/proxy_util.c References: <20080214125600.E03741A983A@eris.apache.org> In-Reply-To: <20080214125600.E03741A983A@eris.apache.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 02/14/2008 01:55 PM, jim@apache.org wrote: > Author: jim > Date: Thu Feb 14 04:55:57 2008 > New Revision: 627728 > > URL: http://svn.apache.org/viewvc?rev=627728&view=rev > Log: > Add in mod_jk's disablereuse analog for mod_proxy. > > Modified: > httpd/httpd/trunk/CHANGES > httpd/httpd/trunk/docs/manual/mod/mod_proxy.xml > httpd/httpd/trunk/modules/proxy/mod_proxy.c > httpd/httpd/trunk/modules/proxy/mod_proxy.h > httpd/httpd/trunk/modules/proxy/proxy_util.c > > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.h > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.h?rev=627728&r1=627727&r2=627728&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original) > +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Thu Feb 14 04:55:57 2008 > @@ -352,6 +352,8 @@ > char ping_timeout_set; > int lbset; /* load balancer cluster set */ > char retry_set; > + char disablereuse; > + char disablereuse_set; > }; I am missing a minor bump due to these changes. > > /* > > Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=627728&r1=627727&r2=627728&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original) > +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Thu Feb 14 04:55:57 2008 > @@ -1698,7 +1698,7 @@ > } > > /* determine if the connection need to be closed */ > - if (conn->close || !worker->is_address_reusable) { > + if (conn->close || !worker->is_address_reusable || worker->disablereuse) { > apr_pool_t *p = conn->pool; > apr_pool_clear(p); > conn = apr_pcalloc(p, sizeof(proxy_conn_rec)); > @@ -1902,8 +1902,13 @@ > if (!worker->retry_set) { > worker->retry = apr_time_from_sec(PROXY_WORKER_DEFAULT_RETRY); > } > - /* By default address is reusable */ > - worker->is_address_reusable = 1; > + /* By default address is reusable unless DisableReuse is set */ > + if (worker->disablereuse) { > + worker->is_address_reusable = 0; Is this really a good idea? Why repeat the DNS resolution only because we want to avoid persistent connections? Regards Rüdiger