Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 79125 invoked from network); 19 Feb 2008 18:49:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Feb 2008 18:49:07 -0000 Received: (qmail 26173 invoked by uid 500); 19 Feb 2008 18:48:55 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 26117 invoked by uid 500); 19 Feb 2008 18:48:55 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 26105 invoked by uid 99); 19 Feb 2008 18:48:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Feb 2008 10:48:55 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [217.160.171.50] (HELO jupiter.hal-nine-zero-zero-zero.net) (217.160.171.50) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 19 Feb 2008 18:48:20 +0000 Received: (qmail 27689 invoked from network); 19 Feb 2008 18:48:28 -0000 Received: from unknown (HELO ?192.168.0.45?) (84.163.18.100) by jupiter.hal-nine-zero-zero-zero.net with SMTP; 19 Feb 2008 18:48:28 -0000 From: =?utf-8?q?Andr=C3=A9_Malo?= Organization: TIMTOWTDI To: dev@httpd.apache.org Subject: Re: svn commit: r629164 - /httpd/httpd/trunk/support/htpasswd.c Date: Tue, 19 Feb 2008 19:48:40 +0100 User-Agent: KMail/1.9.7 References: <20080219170528.909EC1A9832@eris.apache.org> In-Reply-To: <20080219170528.909EC1A9832@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200802191948.41212@news.perlig.de> X-Virus-Checked: Checked by ClamAV on apache.org * pquerna@apache.org wrote: > Author: pquerna > Date: Tue Feb 19 09:05:26 2008 > New Revision: 629164 > > URL: http://svn.apache.org/viewvc?rev=3D629164&view=3Drev > Log: > Improve generation of the seed to rand, by using > apr_generate_random_bytes, rather than the current time as a seed. Wouldn't it make more sense to drop all that seed and rand hassle and just= =20 use the apr-random bytes directly as salt (alphabet[byte % len(alphabet)]) nd =2D-=20 package Hacker::Perl::Another::Just;print qq~@{[reverse split/::/ =3D>__PACKAGE__]}~; # Andr=C3=A9 Malo # http://www.perlig.de #