httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r629164 - /httpd/httpd/trunk/support/htpasswd.c
Date Tue, 19 Feb 2008 20:00:12 GMT


On 02/19/2008 07:48 PM, André Malo wrote:
> * pquerna@apache.org wrote:
> 
>> Author: pquerna
>> Date: Tue Feb 19 09:05:26 2008
>> New Revision: 629164
>>
>> URL: http://svn.apache.org/viewvc?rev=629164&view=rev
>> Log:
>> Improve generation of the seed to rand, by using
>> apr_generate_random_bytes, rather than the current time as a seed.
> 
> Wouldn't it make more sense to drop all that seed and rand hassle and just 
> use the apr-random bytes directly as salt (alphabet[byte % len(alphabet)])

This was also my first thought on this patch.

Regards

RĂ¼diger


Mime
View raw message