httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: ap_sub_req_lookup_* loosing filter context
Date Fri, 08 Feb 2008 23:07:31 GMT


On 02/08/2008 11:34 PM, Dirk-Willem van Gulik wrote:
> 
> On Feb 8, 2008, at 5:45 PM, Plüm, Rüdiger, VF-Group wrote:
> 
>>> However we also occasionally do NOT do this - but make the thus
>>> created sub request as the main request  i.e. some redirect where we
>>> do not discard the sub_req -- but continue to operate on it
>>> (e.g. the
>>> core of mod_dir, mod_negotiation) - and pass it to a
>>> internal(fast)redirect.
>>>
> ...
>> I guess this happens in at least one more location at mod_negotiation
>> that would also need fixing (in setup_choice_response).
> 
> Below are all the only two places I could find. Let me know which ones I
> missed !

IMHO this one is missing:


Index: mod_negotiation.c
===================================================================
--- mod_negotiation.c   (Revision 619126)
+++ mod_negotiation.c   (Arbeitskopie)
@@ -2712,7 +2712,7 @@
     if (!variant->sub_req) {
         int status;

-        sub_req = ap_sub_req_lookup_file(variant->file_name, r, NULL);
+        sub_req = ap_sub_req_lookup_file(variant->file_name, r, r->output_filters));
         status = sub_req->status;

         if (status != HTTP_OK &&

Regards

Rüdiger



Mime
View raw message