httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <ni...@acc.umu.se>
Subject PR41190 - which fix should we use
Date Sat, 12 Jan 2008 15:27:45 GMT

Hi!

Since I no longer have an excuse I thought I should have a go at 
fixing PR41190, mod_rewrite stat:ing the wrong file when using sdbm 
maps.

Read http://issues.apache.org/bugzilla/show_bug.cgi?id=41190 for 
the background, executive summary is that sdbm is the only dbm using 
two files and we're stat:ing the wrong one.

Since this touches apr-util I will need some feedback on how we should 
fix this and not having it reoccur. As I see it we have three options:

1) Fix lookup_map() to stat both files if present. I don't like
    this simply because it's unneccessary since one file usually
    changes with each update and the other seldom changes.

2) Document the last file returned by apr_dbm_get_usednames* as
    the one to check for freshness (which is the current state of
    affairs) and fix cmd_rewritemap() to adhere to this.

3) Change and document the first file returned by
    apr_dbm_get_usednames* as the one to check.

Given that httpd tends to be built with system installed APR/APR-Util 
I'd say that option number two probably would be the best choice in 
order to be able to say that the issue is resolved. However, this 
requires that the suitable docco gets commited to apr-util so it's 
clear that it works (and will work) this way.

Option number three is probably the best way if we want to avoid 
unneccesary code just because the name of the file to check for 
freshness is returned in varying arguments...

I realize that this is as much an apr-util question as an httpd 
question, but I trust those involved in both camps to raise the 
issue with the apr-util crowd if needed.

Thoughts?

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  MULTITASKING:  Locking up more than 1 app @ a time.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Mime
View raw message