httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, VF-Group <ruediger.pl...@vodafone.com>
Subject Re: Pre-release test tarballs of httpd 1.3.40, 2.0.62 and 2.2.7 available
Date Wed, 09 Jan 2008 15:19:22 GMT


> -----Ursprüngliche Nachricht-----
> Von: Jim Jagielski [mailto:jim@jaguNET.com] 
> Gesendet: Mittwoch, 9. Januar 2008 16:17
> An: dev@httpd.apache.org
> Betreff: Re: Pre-release test tarballs of httpd 1.3.40, 
> 2.0.62 and 2.2.7 available
> 
> 
> 
> On Jan 9, 2008, at 9:59 AM, Jim Jagielski wrote:
> 
> >
> > On Jan 9, 2008, at 9:42 AM, Nick Kew wrote:
> >> Not so sure here - we're not really returning an error status in
> >> any case, and sending errors to the backend falls outside the scope
> >> of HTTP.
> >>
> >> I've just voted +1 on keeping that as-is, in the hope of getting
> >> backported in time for Jim's 2.2.8 schedule.
> >
> > Reviewing and testing http://people.apache.org/~niq/ 
> > chunk_optimization.diff
> > as we speak... I'd also like this in 2.2.8...
> >
> 
> In the case where we have nothing but zero-length data buckets
> in the brigade, we leveraging that when we leave the
> loop, we'll be at a sentinel. Even so, any issues with
> the small "can't happen" check below?
> 
>      /* We had no data in this brigade */
>      if (!len || e == APR_BRIGADE_SENTINEL(b)) {
>          return APR_EAGAIN;
>      }
> 
>

No. Safety first.

Regards

Rüdiger 

Mime
View raw message