httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, VF-Group <ruediger.pl...@vodafone.com>
Subject Re: Pre-release test tarballs of httpd 1.3.40, 2.0.62 and 2.2.7 available
Date Wed, 09 Jan 2008 10:15:57 GMT


> -----Ursprüngliche Nachricht-----
> Von: Nick Kew 
> Gesendet: Mittwoch, 9. Januar 2008 01:27
> An: dev@httpd.apache.org
> Betreff: Re: Pre-release test tarballs of httpd 1.3.40, 
> 2.0.62 and 2.2.7 available
> 
> 
> On Mon, 07 Jan 2008 11:29:43 +0100
> Ruediger Pluem <rpluem@apache.org> wrote:
> 
> > I will also propose the optimizations. If someone has cycles to
> > review then fine, if not then in 2.2.9 :-).
> 
> At lines 364 and 460 (trunk), you set HTTP_SERVICE_UNAVAILABLE
> when broken chunking is encountered.  I don't think that's right:

That's because this was the error code that was used there before for
empty chunk size lines, but I agree that this error code might be wrong.

> 
> - bad chunking in a request should return HTTP_BAD_REQUEST
> - bad chunking in a proxy response should return HTTP_BAD_GATEWAY
> 
> Can we know if we're processing request or response at this point?

IMHO unfortunately not, but it does not matter in the proxy case anyway,
because the error messages sent via bail_out_on_error are sent to the backend
server in this case and not the client :-). This is because we have switched
the meaning of INPUT and OUTPUT filters for our proxy connection to the backend.
The client will receive internal server error just as with your test with the
insane sized chunk extension. This is no regression it has worked forever like this.
So in the light of this it might make sense to change this simply from
HTTP_SERVICE_UNAVAILABLE to HTTP_BAD_REQUEST. WDYT?

> 
> Also, I committed a simple edge-case fix against empty data
> buckets getting in the way of detecting a lineend.
> I presume you're OK with r610240?

Thanks. Your patch is much better than my stupid one.

Regards

Rüdiger


Mime
View raw message