httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: Pre-release test tarballs of httpd 1.3.40, 2.0.62 and 2.2.7 available
Date Wed, 09 Jan 2008 00:27:17 GMT
On Mon, 07 Jan 2008 11:29:43 +0100
Ruediger Pluem <rpluem@apache.org> wrote:

> I will also propose the optimizations. If someone has cycles to
> review then fine, if not then in 2.2.9 :-).

At lines 364 and 460 (trunk), you set HTTP_SERVICE_UNAVAILABLE
when broken chunking is encountered.  I don't think that's right:

- bad chunking in a request should return HTTP_BAD_REQUEST
- bad chunking in a proxy response should return HTTP_BAD_GATEWAY

Can we know if we're processing request or response at this point?

Also, I committed a simple edge-case fix against empty data
buckets getting in the way of detecting a lineend.
I presume you're OK with r610240?

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Mime
View raw message