httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: Memory consumption of mod_substitute
Date Sat, 08 Dec 2007 19:39:18 GMT

On Dec 8, 2007, at 2:31 PM, Ruediger Pluem wrote:

>
>
> On 12/08/2007 07:41 PM, Jim Jagielski wrote:
>>
>>>>>
>>>>> On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group
>>>>> <ruediger.pluem@vodafone.com> wrote:
>>>>>> * My test case lead to the exceptional situation of a very
>>>>> large passbb bucket brigade
>>>>>>   (about 1,000,000 buckets) as a result of processing 4 MB
>>>>> of the file. So I add
>>>>>>   a flush bucket once I have more than MAX_BUCKET (1000)
>>>>> buckets in the brigade and pass it
>>>>>>   down the chain to get it send and the passbb bucket
>>>>> brigade cleaned up and its memory
>>>>>>   reusable again.
>>>>>
>>>>>
>>
>> By the by, even though we just use MAX_BUCKET here, it does
>> seem that there is high potential for naming conflicts
>> for this define... Maybe prefix it with some AP_* junk
>> just in case?
>
> Fixed in r602533. You may want to add it to the backport proposal  
> as well.
>

Already done... I updated the rev2 patch in place, since I figured
no one had looked at it yet :)
Mime
View raw message