httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r607466 - in /httpd/httpd/trunk: CHANGES modules/dav/main/util.c
Date Sat, 29 Dec 2007 20:25:02 GMT


On 12/29/2007 08:38 PM, niq@apache.org wrote:
> Author: niq
> Date: Sat Dec 29 11:38:51 2007
> New Revision: 607466
> 
> URL: http://svn.apache.org/viewvc?rev=607466&view=rev
> Log:
> mod_dav: Fix evaluation of If-Match * and If-None-Match * conditionals.
> PR 38034
> Patch by Paritosh Shah
> Explanation by Werner Baumann
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/modules/dav/main/util.c
> 

> Modified: httpd/httpd/trunk/modules/dav/main/util.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/util.c?rev=607466&r1=607465&r2=607466&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/dav/main/util.c (original)
> +++ httpd/httpd/trunk/modules/dav/main/util.c Sat Dec 29 11:38:51 2007
> @@ -1404,6 +1404,37 @@

> @@ -1449,9 +1481,17 @@
>      if (response != NULL)
>          *response = NULL;
>  
> +    /* Set the ETag header required by dav_meets_conditions() */
> +    if ((err = (*resource->hooks->set_headers)(r, resource)) != NULL) {

I agree that setting the ETag header is needed in order to have dav_meets_conditions
/ ap_meets_conditions working, but this means we now set several headers in cases where
we did not set them before (e.g. DELETE method). Is this correct?

Regards

RĂ¼diger


Mime
View raw message