httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Clark <mich...@metaparadigm.com>
Subject Re: [PATCH] Re: thoughts on ETags and mod_dav
Date Sat, 29 Dec 2007 15:12:50 GMT
Michael Clark wrote:
> Patch below makes mod_dav consistent with the format in http_etag.c
> and fixes the cond_put regression with litmus
>
> Index: modules/dav/fs/repos.c
> ===================================================================
> --- modules/dav/fs/repos.c    (revision 607400)
> +++ modules/dav/fs/repos.c    (working copy)
> @@ -1777,10 +1777,10 @@
>         return apr_pstrdup(ctx->pool, "");
>
>     if (ctx->finfo.filetype != 0) {
> -        return apr_psprintf(ctx->pool, "\"%lx-%lx-%lx\"",
> -                           (unsigned long) ctx->finfo.inode,
> -                           (unsigned long) ctx->finfo.size,
> -                           (unsigned long) ctx->finfo.mtime);
> +        return apr_psprintf(ctx->pool, "\"%llx-%llx-%llx\"",
> +                           (apr_uint64_t) ctx->finfo.inode,
> +                           (apr_uint64_t) ctx->finfo.size,
> +                           (apr_uint64_t) ctx->finfo.mtime);
>     }
>
>     return apr_psprintf(ctx->pool, "\"%lx\"", (unsigned long) 
> ctx->finfo.mtime);

Oh, and the mtime only case needs to be changed also.


Mime
View raw message