httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: Adding charset to canned responses
Date Sat, 29 Dec 2007 21:11:53 GMT
On Sat, 29 Dec 2007 20:43:39 +0100
Ruediger Pluem <rpluem@apache.org> wrote:

> > 2. Might ISO-8859-1 be downright wrong in some instances?
> >    Why should we suppose an FTP directory listing is ISO-8859-1?
> 
> I have a patch in the pipe that makes this configurable for
> mod_proxy_ftp. But we thought for the first shot it might be easier
> to hardcode the charset. See further discussion on
> security@httpd.apache.org.

Add your patch to the proposal and that'll fix my objection.

> >    I'd also flag up mod_dav, though I haven't checked how it's
> >    used there.
> 
> I have already checked this. IMHO it is only used for error messages
> and the user supplied data are only URIs which might be in UTF-8 in
> the future but mostly not now. Furthermore it is questionable if
> WebDAV clients display these error messages at all, because not all
> of them are browsers and able to render HTML.

Sounds like a simple and safe fix would be to remove all references to
r->uri in mod_dav's error responses.

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Mime
View raw message