Return-Path: 
 <dev-return-59336-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@www.apache.org
Received: (qmail 6187 invoked from network); 19 Nov 2007 21:41:32 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 19 Nov 2007 21:41:32 -0000
Received: (qmail 45829 invoked by uid 500); 19 Nov 2007 21:41:12 -0000
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 45762 invoked by uid 500); 19 Nov 2007 21:41:12 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
List-Post: <mailto:dev@httpd.apache.org>
List-Id: <dev.httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 45751 invoked by uid 99); 19 Nov 2007 21:41:12 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2007 13:41:12 -0800
X-ASF-Spam-Status: No, hits=0.2 required=10.0
	tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [216.86.168.178] (HELO mxout-03.mxes.net) (216.86.168.178)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2007 21:41:01 +0000
Received: from critterling.garfield.home (unknown [76.182.44.231])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.mxes.net (Postfix) with ESMTP id 91D1A23E496
	for <dev@httpd.apache.org>; Mon, 19 Nov 2007 16:40:53 -0500 (EST)
Received: by critterling.garfield.home (Postfix, from userid 1000)
	id 746E3A018F; Mon, 19 Nov 2007 16:40:52 -0500 (EST)
Date: Mon, 19 Nov 2007 16:40:52 -0500
From: "Victor J. Orlikowski" <victor.j.orlikowski@alumni.duke.edu>
To: dev@httpd.apache.org
Subject: Re: svn commit: r587673 - /httpd/httpd/trunk/server/mpm_common.c
Message-ID: <20071119214051.GA18380@garfield.home>
Mail-Followup-To: dev@httpd.apache.org
References: <20071023220514.C93051A9832@eris.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071023220514.C93051A9832@eris.apache.org>
User-Agent: Mutt/1.5.9i
X-Virus-Checked: Checked by ClamAV on apache.org

On Tue, Oct 23, 2007 at 10:05:14PM -0000, wrowe@apache.org wrote:
<snip> 
> Modified: httpd/httpd/trunk/server/mpm_common.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm_common.c?rev=587673&r1=587672&r2=587673&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/mpm_common.c (original)
> +++ httpd/httpd/trunk/server/mpm_common.c Tue Oct 23 15:05:14 2007
> @@ -565,7 +565,8 @@
>      apr_status_t rv;
>  
>      *pod = apr_palloc(p, sizeof(**pod));
> -    rv = apr_file_pipe_create(&((*pod)->pod_in), &((*pod)->pod_out), p);
> +    rv = apr_file_pipe_create_ex(&((*pod)->pod_in), &((*pod)->pod_out),
> +                                 APR_WRITE_BLOCK, p);
>      if (rv != APR_SUCCESS) {
>          return rv;
>      }

Hrm.
Reviewing this patch, we break prefork w/ it.
Revert, or bring APR_WRITE_BLOCK to the other archs?

Best,
Victor
-- 
Victor J. Orlikowski <> victor.j.orlikowski@alumni.duke.edu