httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Erenkrantz" <jus...@erenkrantz.com>
Subject Re: svn commit: r595028 - /httpd/sandbox/amsterdam/d/modules/proxy/mod_serf.c
Date Wed, 14 Nov 2007 21:47:46 GMT
On Nov 14, 2007 4:18 PM, Ruediger Pluem <rpluem@apache.org> wrote:
> > +    b = APR_BRIGADE_FIRST(ctx->bb);
> > +    status = apr_bucket_read(b, data, len, APR_BLOCK_READ);
>
> Isn't it dangerous that we do not copy *data here?
> Doesn't this data get lost when we delete the bucket in the while loop below?

Yup.  Should be addressed in r595070.

> How do we set *found if the status is not EAGAIN?

Doh.  r595077.

> > +    apr_brigade_pflatten(ctx->bb, data, len, ctx->pool);
>
> Shouldn't this be ctx->tmp_bb?
> Shouldn't we call apr_brigade_cleanup(ctx->tmp_bb) here?

*don paper bag* r595079.

Thanks.  -- justin

Mime
View raw message