httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r587673 - /httpd/httpd/trunk/server/mpm_common.c
Date Mon, 19 Nov 2007 21:53:40 GMT
>> -    rv = apr_file_pipe_create(&((*pod)->pod_in), &((*pod)->pod_out),
p);
>> +    rv = apr_file_pipe_create_ex(&((*pod)->pod_in), &((*pod)->pod_out),
>> +                                 APR_WRITE_BLOCK, p);
>>      if (rv != APR_SUCCESS) {
>>          return rv;
>>      }
> 
> Hrm.
> Reviewing this patch, we break prefork w/ it.
> Revert, or bring APR_WRITE_BLOCK to the other archs?

If you work from APR trunk of a month ago, you should already find that symbol.

It's pretty clear a number of nice changes to httpd 2.4 will require apr 1.3.x.
In fact it would be nice if APR would start coming together around the final
apr 1.3.0 release API, and feedback at dev@apr would be welcomed.

Bill

Mime
View raw message