httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Victor J. Orlikowski" <victor.j.orlikow...@alumni.duke.edu>
Subject Re: svn commit: r587673 - /httpd/httpd/trunk/server/mpm_common.c
Date Mon, 19 Nov 2007 21:40:52 GMT
On Tue, Oct 23, 2007 at 10:05:14PM -0000, wrowe@apache.org wrote:
<snip> 
> Modified: httpd/httpd/trunk/server/mpm_common.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm_common.c?rev=587673&r1=587672&r2=587673&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/mpm_common.c (original)
> +++ httpd/httpd/trunk/server/mpm_common.c Tue Oct 23 15:05:14 2007
> @@ -565,7 +565,8 @@
>      apr_status_t rv;
>  
>      *pod = apr_palloc(p, sizeof(**pod));
> -    rv = apr_file_pipe_create(&((*pod)->pod_in), &((*pod)->pod_out), p);
> +    rv = apr_file_pipe_create_ex(&((*pod)->pod_in), &((*pod)->pod_out),
> +                                 APR_WRITE_BLOCK, p);
>      if (rv != APR_SUCCESS) {
>          return rv;
>      }

Hrm.
Reviewing this patch, we break prefork w/ it.
Revert, or bring APR_WRITE_BLOCK to the other archs?

Best,
Victor
-- 
Victor J. Orlikowski <> victor.j.orlikowski@alumni.duke.edu

Mime
View raw message