httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Covener" <cove...@gmail.com>
Subject Fwd: svn commit: r593283 - in /httpd/httpd/trunk: include/util_ldap.h modules/ldap/util_ldap.c
Date Thu, 08 Nov 2007 20:10:38 GMT
Any thoughts on how to contrast uldap_connection_close() vs
uldap_connection_cleanup()?

uldap_connection_close() tears down the minimal amount, leaving a
bound connection floating around, but the doc talks about tearing the
entire connection down. uldap_connection_cleanup() documents pretty
much the same behavior.

Since close() and cleanup() seem so close to eachother, should we make
them do the same thing and add some operation that's more clearly
unlocking/releasing the pooled connection?

(authnz_ldap's r->pool cleanup would call unlock()/release() pretty
much exclusively)

-- 
Eric Covener
covener@gmail.com

Mime
View raw message