Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 13976 invoked from network); 10 Oct 2007 20:36:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Oct 2007 20:36:47 -0000 Received: (qmail 46434 invoked by uid 500); 10 Oct 2007 20:36:32 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 46360 invoked by uid 500); 10 Oct 2007 20:36:32 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 46349 invoked by uid 99); 10 Oct 2007 20:36:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Oct 2007 13:36:32 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of minfrin@sharp.fm designates 64.49.220.200 as permitted sender) Received: from [64.49.220.200] (HELO chandler.sharp.fm) (64.49.220.200) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Oct 2007 20:36:35 +0000 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id CB404E62D1 for ; Wed, 10 Oct 2007 15:35:43 -0500 (CDT) Received: from 87-194-125-19.bethere.co.uk (87-194-125-19.bethere.co.uk [87.194.125.19]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by chandler.sharp.fm (Postfix) with ESMTP id 66EB7E5521 for ; Wed, 10 Oct 2007 15:35:43 -0500 (CDT) Message-ID: <470D379D.9050009@sharp.fm> Date: Wed, 10 Oct 2007 22:35:41 +0200 From: Graham Leggett User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd) References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Checked: Checked by ClamAV on apache.org Niklas Edmundsson wrote: > What I'd like answered is: > - Was the latest patch as suggested OK? The latest patch was the one with a directive, which is +1 from me - though is it possible to add documentation for the directive? > - What's the correct way of getting the mod_cache configuration from > the mod_disk_cache module? Look inside mod_proxy_http.c for a function called ap_proxy_read_headers(). In it, the module mod_proxy_http reads the config from the module mod_proxy. Regards, Graham --