Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 1690 invoked from network); 9 Oct 2007 09:33:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Oct 2007 09:33:43 -0000 Received: (qmail 75115 invoked by uid 500); 9 Oct 2007 09:33:27 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 75054 invoked by uid 500); 9 Oct 2007 09:33:27 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 75043 invoked by uid 99); 9 Oct 2007 09:33:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2007 02:33:27 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 09 Oct 2007 09:33:31 +0000 Received: (qmail 1524 invoked by uid 2161); 9 Oct 2007 09:33:11 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 86D961721C for ; Tue, 9 Oct 2007 11:32:57 +0200 (CEST) Message-ID: <470B4AD3.1070408@apache.org> Date: Tue, 09 Oct 2007 11:33:07 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c References: <20071008234737.490961A9832@eris.apache.org> In-Reply-To: <20071008234737.490961A9832@eris.apache.org> X-Enigmail-Version: 0.95.2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 10/09/2007 01:47 AM, niq@apache.org wrote: > Author: niq > Date: Mon Oct 8 16:47:35 2007 > New Revision: 583002 > > URL: http://svn.apache.org/viewvc?rev=583002&view=rev > Log: > mod_proxy_http: Don't unescape/escape forward proxied URLs. Just check them. > PR 42592 > > also add fix to PR42572 to CHANGES (from r563487/r563489) > > Modified: > httpd/httpd/trunk/CHANGES > httpd/httpd/trunk/modules/proxy/mod_proxy_http.c > > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=583002&r1=583001&r2=583002&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original) > +++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Mon Oct 8 16:47:35 2007 > @@ -36,6 +36,9 @@ > const char *err; > const char *scheme; > apr_port_t port, def_port; > + const char *p; > + const char *allowed = "~$-_.+!*'(),;:@&=/"; /* allowed+reserved from > + ap_proxy_canonenc */ *allowed could be made 'static'. Otherwise looks good. Regards Rüdiger >