httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@gbiv.com>
Subject Re: svn commit: r581374 - /httpd/httpd/trunk/modules/http/http_core.c
Date Tue, 02 Oct 2007 22:31:25 GMT
On Oct 2, 2007, at 2:15 PM, Ruediger Pluem wrote:
>> -    if ((r->method_number != M_OPTIONS) || !r->uri || strcmp(r- 
>> >uri, "*")) {
>> -        return DECLINED;
>> +    if ((r->method_number == M_OPTIONS) && r->uri && (r->uri[0]
 
>> == '*')) {
>> +        return OK;           /* Send HTTP pong, without Allow  
>> header */
>
> Why OK and not DONE?

No idea how that happened, other than a simple brain fart.
I had first changed

+    if (rv == OK) {
+        rv = DONE;
+    }
+
+    return rv;

to

      return (rv == OK) DONE : rv;

and then removed the ap_allow_standard_methods and ap_send_http_options,
which made rv unnecessary, which naturally caused that line to become

      return OK;

for no good reason. *shrug*

....Roy

Mime
View raw message