httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c
Date Tue, 09 Oct 2007 15:58:38 GMT

On Oct 9, 2007, at 10:58 AM, William A. Rowe, Jr. wrote:

> Jim Jagielski wrote:
>>
>> On Oct 9, 2007, at 5:33 AM, Ruediger Pluem wrote:
>>
>>>> +    const char *allowed = "~$-_.+!*'(),;:@&=/"; /* allowed 
>>>> +reserved
>>>> from
>>>> +                                                    
>>>> ap_proxy_canonenc */
>>>
>>> Otherwise looks good.
>>>
>>
>> Would almost make sense to have this as an API function... anyone  
>> have
>> issues if I make the required adjustments for that to happen?
>
> Uhm - isn't this what uri_delims is for???
>

We're not looking for deliminators, we're looking for "invalid"
chars in a URL. So something like ap_proxy_validurl() or
ap_proxy_good_encoding()...

I can think of a few places where we'd want to replicate and
reuse this...


Mime
View raw message