Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jfclere@gmail.com designates
 66.249.82.235 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=CNGLNLONnAQWcFG56/vKJIJXClSm6Sy0mkFrWm4IL0iyFEkOYWXCpXdrNvQT7f8wyDD4bVYQXzHjKtW56eWD6YehKcTX1kBP7I3GMkN29wRROKAh106Dm/4vsSTTcXYmMFsadCfBmjgM/P9B+OXc8uP9M6ymNk/lW+M4oAJKmac=
Message-ID: <46E7C2E6.5020902@gmail.com>
Date: Wed, 12 Sep 2007 12:43:50 +0200
From: jean-frederic clere <jfclere@gmail.com>
User-Agent: Thunderbird 2.0.0.5 (X11/20070719)
MIME-Version: 1.0
To: dev@httpd.apache.org
CC: Jim Jagielski <jim@jaguNET.com>
Subject: Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h
References: 
 <3B21A253728EA247A10A692547A271530213F713@EITO-MBX03.internal.vodafone.com>
 <46E6BDB2.9000102@gmail.com>
 <7E29E305-EF0E-4A74-8971-CDC3972390D3@jaguNET.com>
 <46E6C5F5.7000207@gmail.com>
 <C2659787-D219-4ED6-AE61-4338539E8B26@jaguNET.com>
In-Reply-To: <C2659787-D219-4ED6-AE61-4338539E8B26@jaguNET.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

Jim Jagielski wrote:
> 
> On Sep 11, 2007, at 12:44 PM, jean-frederic clere wrote:
> 
>> Jim Jagielski wrote:
>>>
>>> On Sep 11, 2007, at 12:09 PM, jean-frederic clere wrote:
>>>
>>>>>
>>>>> 1. IMHO requires a minor bump.
>>>>
>>>> Find a patch that covers all the points you raised below.
>>>>
>>>> More comments?
>>>>
>>>
>>> Requires a major bump. Also destroys all those mystical
>>> other "balancers" from working as-is, since they
>>> must now be not only recompiled but also re-coded to
>>> implement ap_proxy_lb_worker_size() so that the
>>> old "lb_score" entry exists and has some size associated
>>> with it...
>>
>> ap_proxy_lb_worker_size is in mod_proxy as R�diger suggested it.
> 
> My point is that this function must be defined by any "other"
> balancer that wants to use this scoreboard space. You had
> mentioned concern that we can't be monkeying all that
> much with lb_score and stuff because "other" balancers
> may be wanting to use it. This patch does nothing to
> help that really... once the API breaks, well, we
> can do whatever we want :)
> 
>>
>> I agree it can't be backported to 2.2 but why can't it by in trunk?
>>
> 
> Never said it couldn't. Just made a comment that this
> patch isn't suitable for backporting. If I didn't care
> about a backportable patch, I would have originally created
> something quite different than what I did. 2.2 *still* has
> the problem. Instead, we're fixing something that doesn't
> have a problem... :/
> 
> Of course, all this assumes that the present usage of
> a general scoreboard is still the right design choice.
> Personally, as was discussed awhile ago, we need
> a better abstraction as well as moving *away* from
> a general purpose-shove-everything-in-here scoreboard.

I tried something in that direction in
httpd/branches/httpd-proxy-scoreboard. The goal was to offer another
storage for the proxy_worker_stat of mod_proxy.
What do you want to do?

Cheers

Jean-Frederic