Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 43415] Logging remote port.
Date: Wed, 19 Sep 2007 11:47:03 +0200
Message-ID: 
 <3B21A253728EA247A10A692547A271530213F765@EITO-MBX03.internal.vodafone.com>
In-Reply-To: <46F0E80F.9030609@one.com>
Thread-Topic: Re: [PATCH 43415] Logging remote port.
Thread-Index: Acf6nVmHX9moMre4SGOyGcpBGP6AzgAA2s1Q
From: =?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_VF-Group?=
 <ruediger.pluem@vodafone.com>
To: <dev@httpd.apache.org>


> -----Urspr=FCngliche Nachricht-----
> Von: Adam Hasselbalch Hansen=20
> Gesendet: Mittwoch, 19. September 2007 11:13
> An: dev@httpd.apache.org
> Betreff: Re: [PATCH 43415] Logging remote port.
>=20
>=20
> Pl=FCm wrote:
>=20
> > 1. Please provide a patch against trunk.
>=20
> mod_config_logger.c hasn't changed in trunk, so the patch=20
> will work fine.

Sorry. Just a default comment if someone sends in a patch that is not
against trunk :-).

>=20
> > 2. Please also add a patch for the documentation.
>=20
> Done.

Fine, I have already seen it in the report.

>=20
> > 3. I am not too happy with using %R, but to be honest I=20
> have no better proposal :-).
> >    Maybe other have.
>=20
> Well, then... ;)

I will leave around for just one or two days. If nobody has a better
idea we just take %R. Feel free to bug me if your patch falls off my =
radar.

>=20
> > 4.=20
> >=20
> > Instead of using
> > +	return apr_psprintf(r->pool, "%u",=20
> r->connection->remote_addr->port);
> > I would prefer
> > +	return  pfmt(r->pool, (int) (r->connection->remote_addr->port));
> > like used for log_status.
>=20
> Well, in log_server_port, apr_psprintf is used, so that's=20
> what I used.=20
> But I really don't care one way or the other. Is there a particular=20
> reason for using one or the other?

I think that using pfmt is more efficient and burns less cycles than =
apr_psprintf
(I think this would be also the case for log_server_port), but I may be =
wrong on this.
Additionally pfmt checks if port is <=3D 0 and logs a "-" in this case, =
but this should not
be the case for r->connection->remote_addr->port, so we could use =
format_integer or
apr_itoa directly.

Regards

R=FCdiger