Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Mon, 17 Sep 2007 09:14:54 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: AW: SSL_VERSION_LIBRARY
Message-ID: <20070917081454.GB26963@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: 
 <3B21A253728EA247A10A692547A271530213F708@EITO-MBX03.internal.vodafone.com>
 <46E59F4C.7020008@apache.org> <20070911093502.GA14245@redhat.com>
 <46E9445A.3010809@rowe-clan.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <46E9445A.3010809@rowe-clan.net>
User-Agent: Mutt/1.4.2.1i
Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor,
 Berkshire, SL4 1TE, United Kingdom.
  Registered in UK and Wales under Company Registration No. 03798903
  Directors: Michael Cunningham (USA), Brendan Lane (Ireland),
 Matt Parson (USA), Charlie Peters (USA)

On Thu, Sep 13, 2007 at 09:08:26AM -0500, William Rowe wrote:
> Joe Orton wrote:
> > On Mon, Sep 10, 2007 at 09:47:24PM +0200, Ruediger Pluem wrote:
> >> On 09/10/2007 08:40 AM, Plüm wrote:
> >>> That was the goal of my diagnostic patch: Finding out if we have a pool
> >>> issue. Looks like we have. I guess the right fix is as you say 
> >>> to use the parent pool (process scope).
> >> Not 100% sure regarding the correct pool, but would that be the correct fix
> > 
> > That's not really thread-safe, and it ought to be, though we might get 
> > away with it since it's called during startup.  But rather than guessing 
> > pools, actually caching the stuff once at startup is probably cleanest, 
> 
> I've reviewed, I'd be entirely happy with the short-and-sweet hack on
> 2.0 and 2.2 if you would like this to become the new logic for trunk.
> Would that appeal?

I guess that's fine.  It should at least be explicitly documented in the 
2.0/2.2 backports as "here be dragons".

Regards,

joe