httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: AW: mod_proxy_balancer
Date Mon, 10 Sep 2007 14:05:54 GMT

On Sep 10, 2007, at 9:18 AM, Plüm, Rüdiger, VF-Group wrote:

>
>
>> -----Ursprüngliche Nachricht-----
>> Von: vpetrucci@gmail.com
>> Auftrag von Vinicius Petrucci
>> Gesendet: Mittwoch, 5. September 2007 18:09
>> An: dev@httpd.apache.org
>> Betreff: Re: AW: mod_proxy_balancer
>>
>>
>> Well, debugging a little bit more... I realize that the condition
>> (worker is already initialized?) in proxy_util.c(1672) is always
>> bypassed, which is the same condition used by the Rüdiger's patch.
>>
>> But, in proxy_util.c(1706) the same condition is rechecked (the
>> comment says "Possible if proxy is using scoreboard to hold shared
>> stats").
>
> This is the reason why my patch does not work. Attached two  
> proposed solutions:
>
> worker_init_patch_plus_r572937.diff: A simple and nice solution,  
> but IMHO it is not
> backportable as it changes the API.
> worker_init_patch_plus_r572937_back.diff: A more complex and nasty  
> solution that IMHO is
> backportable.
>
> Both patches require r572937 to be applied first.
>
> Can you please give both patches a try?
>
> Other comments welcome as well.
>

Regarding the 2nd one... the:

+            else {
+                worker_is_initialized = 0;
+            }

seems redundant... But other than that nit, looks good!


Mime
View raw message