httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r574884 - /httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
Date Thu, 13 Sep 2007 14:03:53 GMT
William A. Rowe, Jr. wrote:
> Joe Orton wrote:
>> Ewww.  This passes around a process-global pool to functions which can 
>> get invoked at any time during request processing, which just invites a 
>> thread-safety fubar down the line.  It only happens to be safe now 
>> because the function is invoked at startup.
> 
> We call this during each config iteration, logging (even if logs are off
> we call the silly function) the version in-use.  Ergo it's never NULL once
> we've spun off threads and are off to the races.

Would you be happier with a comment at the initialization formatting call
which says "this call is required to initialize the ssl version string"?

Mime
View raw message