httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfcl...@gmail.com>
Subject Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h
Date Mon, 10 Sep 2007 11:23:12 GMT
Plüm wrote:
> 
>> -----Ursprüngliche Nachricht-----
>> Von: jean-frederic clere 
>> Gesendet: Montag, 10. September 2007 12:01
>> An: dev@httpd.apache.org
>> Betreff: Re: svn commit: r573264 - 
>> /httpd/httpd/trunk/include/scoreboard.h
>>
>>
>> Jim Jagielski wrote:
>>> Ruediger Pluem wrote:
>>>> Because it was
>>>>
>>>> int ap_proxy_lb_workers(void);
>>>>
>>>> and not
>>>>
>>>> PROXY_DECLARE(int)ap_proxy_lb_workers(void);
>>>>
>>> Yep. Ideally, of course, a design like mod_ssl with the
>>> ssl_private.h usage is nice, because there you can
>>> expose functions that need to be shared amoung files
>>> (without each one having lines and lines of 'extern foo'
>>> sillyness) without "leaking" them out anyplace
>>> else.
>>>
>> For example what about adding:
>> static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size) 
>> *proxy_lb_worker_size;
>> and use a void * in scoreboard and an int for the size?
> 
> For me this sounds fine, but I would guess that Jim doesn't like
> the void * idea in the scoreboard.

The scoreboard doesn't need to know what it stores ;-).
In fact that information could go in any "shared" memory, the scoreboard
is just the easiest way to handle it.

Cheers

Jean-Frederic

> 
> Regards
> 
> Rüdiger
> 
> 


Mime
View raw message