httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r571879 - /httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c
Date Sun, 02 Sep 2007 08:42:33 GMT
Nick Kew wrote:
> ObPedant:
> 
>> 14:42:30 2007 @@ -113,8 +113,8 @@ 
>>      /* we break the URL into host, port, uri */
>>      if (APR_SUCCESS != apr_uri_parse_hostinfo(p, url, &uri)) {
>> -    return ap_proxyerror(r, HTTP_BAD_REQUEST,
>> -                 apr_pstrcat(p, "URI cannot be parsed: ", url,
>> NULL));
>> +        return ap_proxyerror(r, HTTP_BAD_REQUEST, apr_pstrcat(p,
>> +                             "URI cannot be parsed: ", url, NULL));
> 
> The second arg to ap_pstrcat is presented as a new arg to ap_proxyerror.
> The old formatting was better.

+1 to niq's observation

 - this is now quite illegible in terms of how it is doing what it does.

Mime
View raw message