httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, VF-Group <ruediger.pl...@vodafone.com>
Subject Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h
Date Mon, 10 Sep 2007 15:08:24 GMT


> -----Ursprüngliche Nachricht-----
> Von: Jim Jagielski 
> Gesendet: Montag, 10. September 2007 16:51
> An: dev@httpd.apache.org
> Betreff: Re: svn commit: r573264 - 
> /httpd/httpd/trunk/include/scoreboard.h
> 
> 
> 
> On Sep 10, 2007, at 10:37 AM, jean-frederic clere wrote:
> 
> >
> >  typedef struct ap_sb_handle_t ap_sb_handle_t;
> > @@ -181,7 +175,7 @@
> >  AP_DECLARE(worker_score *) ap_get_scoreboard_worker(int x, int y);
> >  AP_DECLARE(process_score *) ap_get_scoreboard_process(int x);
> >  AP_DECLARE(global_score *) ap_get_scoreboard_global(void);
> > -AP_DECLARE(lb_score *) ap_get_scoreboard_lb(int lb_num);
> > +AP_DECLARE(void *) ap_get_scoreboard_lb(int lb_num);
> >
> >  AP_DECLARE_DATA extern scoreboard *ap_scoreboard_image;
> >  AP_DECLARE_DATA extern const char *ap_scoreboard_fname;
> > @@ -205,6 +199,12 @@
> >    */
> >  APR_DECLARE_OPTIONAL_FN(int, ap_proxy_lb_workers,
> >                          (void));
> > +/**
> > +  * proxy load balancer
> > +  * @return the size of lb_workers.
> > +  */
> > +APR_DECLARE_OPTIONAL_FN(int, ap_proxy_lb_worker_size,
> > +                        (void));
> >
> >  /* for time_process_request() in http_main.c */
> >  #define START_PREQUEST 1
> 
> Changes API. As such, this cannot be backported
> to 2.2.

Yep. So it would be even a major bump. OTOH changing the
typedef of lb_score would also require a major bump in this case,
as in both cases (typedef change / patch above) the return type
remains a pointer, but the type of the pointer would change in both
cases which could be seen as an API breakage.

Sorry for being a pain in the neck with this topic :-)

Regards

Rüdiger



Mime
View raw message