httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinicius Petrucci" <vpetru...@ic.uff.br>
Subject Re: AW: mod_proxy_balancer
Date Mon, 10 Sep 2007 16:16:52 GMT
I've tried the 1st patch (which is simpler and nicer) in httpd-trunk
and now It seems to work... :)

On 10/09/2007, Jim Jagielski <jim@jagunet.com> wrote:
>
> On Sep 10, 2007, at 10:42 AM, Plüm, Rüdiger, VF-Group wrote:
>
> >
> >
> >> -----Ursprüngliche Nachricht-----
> >> Von: Jim Jagielski
> >> Gesendet: Montag, 10. September 2007 16:06
> >> An: dev@httpd.apache.org
> >> Betreff: Re: AW: mod_proxy_balancer
> >>
> >
> >>
> >> Regarding the 2nd one... the:
> >>
> >> +            else {
> >> +                worker_is_initialized = 0;
> >> +            }
> >>
> >> seems redundant... But other than that nit, looks good!
> >
> > Point taken. Thanks for catching it.
> > My approach would be to commit the 2nd patch first, get it backported
> > and improve things on trunk with the first patch afterwards.
> > Another approach would be to commit the first patch to trunk and
> > propose
> > the second for backport. I am not sure about the best approach here.
> >
>
> The 1st sounds better to me... And it's not *that* ugly :) :)
>
>


-- 
Vinicius Tavares Petrucci
home page: http://www.ic.uff.br/~vpetrucci

Mime
View raw message