httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: svn commit: r571203 - /httpd/httpd/branches/2.2.x/modules/proxy/ajp_header.c
Date Thu, 30 Aug 2007 15:47:33 GMT
On 8/30/07, Jeff Trawick <trawick@gmail.com> wrote:
> On 8/30/07, martin@apache.org <martin@apache.org> wrote:
> > Author: martin
> > Date: Thu Aug 30 08:22:58 2007
> > New Revision: 571203
> >
> > URL: http://svn.apache.org/viewvc?rev=571203&view=rev
> > Log:
> > Add missing end-of-string checks by using strcmp in place of memcmp
>
> memcmp() is not needed when you know the length of one of the strings;
> there's no missing check.  The style on the other hand is subject to
> debate.
>
> Meanwhile there may be a bug fix buried in here -- using
> case-insignificant comparison for a HTTP header field name.

I guess it is shame on me for not reading prior dev@httpd posts to
understand the commit message.

Mime
View raw message